[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-23 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Meh, is `__fp16` something I need to check support for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llvm.org/D146436 ___ cfe-commits mailing list cf

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-23 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0691bcb18024: [clang][Interp][NFC] Add tests for __fp16 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llv

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llvm.org/D146436 ___ cfe-commits mailing list

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/test/AST/Interp/floats.cpp:110-111 + + static_assert(~2.0f == 3, ""); // ref-error {{invalid argument type 'float' to unary expression}} \ + // expected-error {{invalid argument type 'float' to un

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 506701. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146436/new/ https://reviews.llvm.org/D146436 Files: clang/test/AST/Interp/floats.cpp Index: clang/test/AST/Interp/floats.cpp ===

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/floats.cpp:110-111 + + static_assert(~2.0f == 3, ""); // ref-error {{invalid argument type 'float' to unary expression}} \ + // expected-error {{invalid argument type 'float'

[PATCH] D146436: [clang][Interp][NFC] Add tests for __fp16

2023-03-20 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should already work just fine since our `Float