This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6cef325481a8: [clang-format] Don't squash Verilog
escaped identifiers (authored by sstwcw).
Changed prior to commit:
https://reviews.llvm.org/D146
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Format/FormatTestVerilog.cpp:19
protected:
- static std::string format(llvm::StringRef Code, unsigned Offset,
-
sstwcw marked an inline comment as done.
sstwcw added inline comments.
Comment at: clang/unittests/Format/FormatTestVerilog.cpp:897
}
+} // namespace
+} // namespace test
MyDeveloperDay wrote:
> is this correct? do you have an anonymous namespace?
It is correct.
MyDeveloperDay added inline comments.
Comment at: clang/unittests/Format/FormatTestVerilog.cpp:897
}
+} // namespace
+} // namespace test
is this correct? do you have an anonymous namespace?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
sstwcw created this revision.
sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel.
Herald added a project: All.
sstwcw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
An escaped identifier always needs a space follow
