This revision was automatically updated to reflect the committed changes.
Closed by commit rGc1ab19850d5c: [Clang][OpenMP]Solved the the always truth
condition in Arm64 (authored by samuelmaina, committed by xgupta).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
samtebbs added a comment.
Thank you Samuel. Since you don't have commit access, I can commit this for you
if you'd like.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146370/new/
https://reviews.llvm.org/D146370
___
cfe-commits mailing list
samuelmaina added a comment.
All the testcases are passing. The first unit tests I could find are for
functions that are 6 levels higher from this function .The function is very
low level and couldn't find a way to affect it from the higher functions.
CHANGES SINCE LAST ACTION
https://revie
samuelmaina updated this revision to Diff 508381.
samuelmaina edited the summary of this revision.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146370/new/
https://reviews.llvm.org/D146370
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
Index: clang/lib/CodeGen/CGOpenMPRuntime.cpp
efriedma added a comment.
The patch is currently impossible to read; please don't clang-format the whole
file. There's a script clang-format-diff.py that can format just the parts of
a file you change, if you need it.
As noted in the discussion on the bug report, needs a testcase.
Repository
samuelmaina updated this revision to Diff 506345.
samuelmaina added a comment.
Updating D146370: [Clang][OpenMP]Solved the the always truth condition in Arm64
===
Reformatted the file
Reformatted the CGOpenMPRuntime.cpp
samuelmaina created this revision.
Herald added subscribers: sunshaoce, guansong, kristof.beyls, yaxunl.
Herald added a project: All.
samuelmaina requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, jplehr, sstefan1.
Herald added a project: c
