This revision was automatically updated to reflect the committed changes.
Closed by commit rG8c10256734cd: clang-tidy: Detect use-after-move in
CXXCtorInitializer (authored by MarcoFalke).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
ht
MarcoFalke marked 2 inline comments as done.
MarcoFalke added a comment.
Minor NFC, I plan to land this tomorrow or Friday
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
https://reviews.llvm.org/D146288
___
cfe-commits mailing list
MarcoFalke updated this revision to Diff 507304.
MarcoFalke added a comment.
NFC
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
https://reviews.llvm.org/D146288
Files:
clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
clang-tools-extra/docs/ReleaseNotes.rst
c
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
Overall LGTM, give it few days, maybe something will pop up.
I will try to run this change on my project and check if it finds any
false-positives or real-issues.
CHANGES SINCE LAST ACTIO
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1431
std::string val_;
};
MarcoFalke wrote:
> PiotrZSL wrote:
> > MarcoFalke wrote:
> > > PiotrZSL wrote:
> > > > Missing tests:
> > > > - Test
MarcoFalke marked 3 inline comments as done.
MarcoFalke added a comment.
Thanks, addressed some more review comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1431
std::string val_;
};
PiotrZSL wrote:
> MarcoFalke
MarcoFalke updated this revision to Diff 506632.
MarcoFalke added a comment.
address feedback about matcher, clang-format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
https://reviews.llvm.org/D146288
Files:
clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
cl
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1431
std::string val_;
};
MarcoFalke wrote:
> PiotrZSL wrote:
> > Missing tests:
> > - Test with A derive from B, C, D, and argument is moved i
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:400
void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) {
auto CallMoveMatcher =
+ callExpr(
MarcoFalke wrote:
> PiotrZSL wrote:
> > This is
MarcoFalke added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:400
void UseAfterMoveCheck::registerMatchers(MatchFinder *Finder) {
auto CallMoveMatcher =
+ callExpr(
PiotrZSL wrote:
> This is correct but conside
MarcoFalke updated this revision to Diff 506586.
MarcoFalke marked an inline comment as done.
MarcoFalke added a comment.
Took some review suggestions (Thanks!)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
https://reviews.llvm.org/D146288
Files:
clang-tools-extra/clang-t
PiotrZSL requested changes to this revision.
PiotrZSL added a comment.
This revision now requires changes to proceed.
Requesting changes due to lack of support for base class initializes & got some
concerns related lambdas used in initializers.
Comment at: clang-tools-extra/cl
PiotrZSL added a comment.
I will check this more deeply during weekend.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
https://reviews.llvm.org/D146288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
MarcoFalke updated this revision to Diff 506081.
MarcoFalke added a comment.
sort doc
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
https://reviews.llvm.org/D146288
Files:
clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
clang-tools-extra/docs/ReleaseNotes.rs
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:190
+- Improved :doc:`bugprone-use-after-move
+ ` check to also cover constructor
Please keep alphabetical order (by check name) in this section.
CHANGES SINCE LAST ACT
MarcoFalke updated this revision to Diff 506055.
MarcoFalke added a comment.
clang-format+doc
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146288/new/
https://reviews.llvm.org/D146288
Files:
clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp
clang-tools-extra/docs/Release
MarcoFalke created this revision.
MarcoFalke added a project: clang-tools-extra.
Herald added subscribers: PiotrZSL, carlosgalvezp.
Herald added a reviewer: njames93.
Herald added a project: All.
MarcoFalke requested review of this revision.
Herald added a subscriber: cfe-commits.
Fixes https://gi
17 matches
Mail list logo
