[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah added inline comments. Herald added a subscriber: bviyer. Comment at: flang/include/flang/Tools/CLOptions.inc:251 +bool stackArrays = false, bool underscoring = true, bool useHLFIR = false) { + if (useHLFIR) +fir::createHLFIRToFIRPassPipeline(pm, optLevel); --

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacf6a3224955: [flang] add -flang-experimental-hlfir flag to flang-new (authored by tblah). Changed prior to commit: https://reviews.llvm.org/D1462

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: flang/test/HLFIR/flang-experimental-hlfir-flag.f90:19 +! CHECK-NEXT: } +! NO-HLFIR-NOT: hlfir. [ultra nit] I would separat

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 507321. tblah added a comment. Thanks for the suggestion - Added a test to check that hlfir is not output without the flag - clang-formatted CLOptions.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added inline comments. Comment at: flang/test/HLFIR/flang-experimental-hlfir-flag.f90:2 +! Test -flang-experimental-hlfir flag +! RUN: %flang_fc1 -flang-experimental-hlfir -emit-fir -o - %s | FileCheck %s + Could you also add a `RUN` line like this: ``

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 507026. tblah added a comment. Added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added a comment. LGTM Please address @awarzynski's comment about the test. Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOpt

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added inline comments. Comment at: flang/test/Driver/mlir-pass-pipeline.f90:15-18 +! O2-NEXT: Canonicalizer +! ALL-NEXT: LowerHLFIRIntrinsics +! ALL-NEXT: BufferizeHLFIR +! ALL-NEXT: ConvertHLFIRtoFIR tblah wrote: > awarzynski wrote: > > It looks like

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOptLevel) { vzakhari wrote: > Would you min

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added inline comments. Comment at: flang/test/Driver/mlir-pass-pipeline.f90:15-18 +! O2-NEXT: Canonicalizer +! ALL-NEXT: LowerHLFIRIntrinsics +! ALL-NEXT: BufferizeHLFIR +! ALL-NEXT: ConvertHLFIRtoFIR It looks like these passes are run unconditionally

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 506544. tblah marked 2 inline comments as done. tblah added a comment. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendo

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tschuett added a comment. You can either pass parameters to passes or use different pass pipelines for different optimisation levels (in MLIR territory). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278 _

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:238 + pm.addPass(mlir::createCanonicalizerPass()); + pm.addPass(hlfir::createLowerHLFIRIntrinsicsPass()); + pm.addPass(hlfir::createBufferizeHLFIRPass()); I would imagine we ma

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added a comment. Thank you for working on this! Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOptLevel) { W

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski added a comment. Could you add some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146278/new/ https://reviews.llvm.org/D146278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah created this revision. tblah added reviewers: jeanPerier, vzakhari, clementval. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers: