[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

2023-03-16 Thread Tang Wenyu via Phabricator via cfe-commits
Tedlion updated this revision to Diff 505802. Tedlion edited the summary of this revision. Tedlion added a comment. Provide the full diff context instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146194/new/ https://reviews.llvm.org/D146194 F

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

2023-03-16 Thread Tang Wenyu via Phabricator via cfe-commits
Tedlion accepted this revision. Tedlion added a comment. I argee that the different CSA behavior between C and C++ should be checked. In D146194#4199257 , @steakhal wrote: > As per your proposed change, I think we should do something like this: > > for

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

2023-03-16 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. BTW we request full context for git patches. That way the reviewer can scroll and see the context around your hunks. You can request git to emit the full context by passing the `-U99` commandline option. See

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

2023-03-16 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Okay, thanks for clarifying. So, it seems like it depends on the language flavor, but why does CSA behave differently in C and C++? This is necessary to understand if we need to fix that instead of patching this particular checker. I'd still add a test to the `clang/t

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

2023-03-16 Thread Tang Wenyu via Phabricator via cfe-commits
Tedlion requested review of this revision. Tedlion added a comment. In D146194#4198870 , @steakhal wrote: > Thanks for looking into this. > > I could not reproduce the issue with the following test code: > https://godbolt.org/z/hsY9PTKGz > > struct A

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

2023-03-16 Thread Balázs Benics via Phabricator via cfe-commits
steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Thanks for looking into this. I could not reproduce the issue with the following test code: https://godbolt.org/z/hsY9PTKGz struct A { unsigned x : 3; unsigned : 29;

[PATCH] D146194: NOT report the warning that unnamed bitfields are uninitialized.

2023-03-15 Thread Tang Wenyu via Phabricator via cfe-commits
Tedlion created this revision. Tedlion added a reviewer: clang. Tedlion added a project: clang. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. Tedlion requested review of this revision. Herald added a subscriber: cfe-commits. I found current