This revision was automatically updated to reflect the committed changes.
Closed by commit rG731264b0c2af: [clang][NFC] Fix location of 2>&1 in a
few -print tests (authored by ldionne).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146155/new/
https
MaskRay added a comment.
Thank you!
(A somewhat common practice is to prefer `[test]` over `[NFC]` for pure-test
changes (no code change) :)
I see that " in a few -print tests" in the subject may render `[test]`
unneeded.. perhaps what tag is used isn't really important.)
Repository:
rG LLV
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146155/new/
https://reviews.llvm.org/D146155
___
cfe-commits mailing list
cfe-comm
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146155/new/
https://reviews.llvm.org/D146155
___
ldionne added a reviewer: aaron.ballman.
ldionne added a comment.
Gentle ping, this was likely a copy-paste error.
Adding Aaron in case he has time to take a look.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146155/new/
https://reviews.llvm.org/
ldionne created this revision.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
While it's apparently valid to place Bash redirections anywhere in a
command-line, it is by far most frequently placed last.
