[PATCH] D146041: Fix weirdly apologetic diagnostic messages

manas added a comment. Hi, I came across this due to changes in Static Analyzer. One of the changes is not related to the Github issue mentioned above. Maybe we can drop that file? Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1214-1215

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

ipriyanshi1708 added a comment. Hi @AryanGodara , I am an Outreachy applicant. I was also working on this issue and also created a patch for this issue i.e., https://reviews.llvm.org/D146530 . Can we collaborate to solve this issue so that only one patch will be there for a issue as told by @aa

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

rsmith added a comment. I have no strong opinions on the merits of this patch in either direction; I think the "sorry"s in the Sema diagnostics for regrettable non-conformance make Clang marginally friendlier, but they do nothing to actually help people who encounter the diagnostic. FWIW, the

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

aaron.ballman added a comment. In D146041#4198056 , @AryanGodara wrote: > I will try to split this commit, and update on this asap (Sorry for the late > update, I have mid-sem exams going on, I haven't abandoned this issue, still > working on it). No

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4195992 , @DavidSpickett wrote: >> Since this is my first commit to such a large repository(and project), can >> you please guide me with this @DavidSpickett ! > > Sure, you'll want to make a commit that only has

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. > Since this is my first commit to such a large repository(and project), can > you please guide me with this @DavidSpickett ! Sure, you'll want to make a commit that only has changes to warnings and errors. You can split up this one to do that, see part "A)" of th

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193172 , @junaire wrote: > I'm not certain if it's bad to say 'sorry', IMHO it's fine? > > Anyway, you can't just simply delete those words (in diagnostic messages and > regression tests), that doesn't work. To ve

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4193045 , @DavidSpickett wrote: > Is there some standard for writing warning messages? For llvm that is, it > would be worth looking through the getting started guides to see. I think the > majority of warnings a

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4192816 , @mehdi_amini wrote: > You should look into the title and description of the commit: > https://cbea.ms/git-commit/ Is the title and description appropriate now? I can add more details to the description,

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

junaire added a comment. I'm not certain if it's bad to say 'sorry', IMHO it's fine? Anyway, you can't just simply delete those words (in diagnostic messages and regression tests), that doesn't work. To verify the patch is good, you can run `ninja check-all` to make sure the testsuite passes.

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. Ah, here it is: https://llvm.org/docs/CodingStandards.html#error-and-warning-messages Seems to back you up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146041/new/ https://reviews.llvm.org/D146041 ___

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. Is there some standard for writing warning messages? For llvm that is, it would be worth looking through the getting started guides to see. I think the majority of warnings are "formal" in that sense so this seems fine. Personally I agree with making the warnings