[PATCH] D145999: [RISCV] Reserve X18 by default for Android

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d0e5e79b0f3: [RISCV] Reserve X18 by default for Android (authored by AdityaK <1894981+hiradi...@users.noreply.github.com>). Repository: rG LLVM G

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

hiraditya updated this revision to Diff 505378. hiraditya added a comment. Folded D145979 here CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999 Files: clang/test/Driver/sanitizer-ld.c llvm/lib/TargetParser

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

hiraditya added inline comments. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +// RUN: %clang --target=riscv64-linux-android -### %s 2> %t MaskRay wrote: > MaskRay wrote: > > asb wrote: > > > sa

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +// RUN: %clang --target=riscv64-linux-android -### %s 2> %t asb wrote: > samitolvanen

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

asb accepted this revision. asb added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

asb added inline comments. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +// RUN: %clang --target=riscv64-linux-android -### %s 2> %t samitolvanen wrote: > This seems redundant. Isn't the LLVM co

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

samitolvanen accepted this revision. samitolvanen added a comment. LGTM. Folding D145979 into this one might also make sense. Comment at: clang/test/Driver/riscv-fixed-x-register.c:343 + +// Check that x18 is reserved on Android by default +/

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145999/new/ https://reviews.llvm.org/D145999 ___

[PATCH] D145999: [RISCV] Reserve X18 by default for Android

hiraditya created this revision. hiraditya added reviewers: enh, asb. Herald added subscribers: jobnoorman, luke, VincentWu, abrachet, danielkiss, vkmr, frasercrmck, evandro, phosek, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbec