[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

2023-04-04 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee71cbddb77f: [clang][Interp] Ignore more non-VarDecl declarations (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D14586

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

2023-03-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145861/new/ https://reviews.llvm.org/D145861 ___ cfe-commits mailing lis

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

2023-03-14 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 505092. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145861/new/ https://reviews.llvm.org/D145861 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

2023-03-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:224 for (auto *D : DS->decls()) { -if (isa(D)) +if (isa(D)) continue; tbaeder wrote: > aaron.ballman wrote: > > What about other kinds of declarations, suc

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

2023-03-13 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:224 for (auto *D : DS->decls()) { -if (isa(D)) +if (isa(D)) continue; aaron.ballman wrote: > What about other kinds of declarations, such as typedefs or function

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

2023-03-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:224 for (auto *D : DS->decls()) { -if (isa(D)) +if (isa(D)) continue; What about other kinds of declarations, such as typedefs or functions? ``` typedef in

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

2023-03-11 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a subscriber: kristof.beyls. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. They ar