[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

2023-03-10 Thread Craig Topper via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2800d57e124a: [RISCV] Error if F and Zfinx extensions are specified together. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHA

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

2023-03-10 Thread Alex Bradbury via Phabricator via cfe-commits
asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145809/new/ https://reviews.llvm.org/D145809

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

2023-03-10 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 504203. craig.topper added a comment. Add test for D and Zdinx which will produce the same error as F and Zfinx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145809/new/ https://reviews.llvm.org/D145809

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

2023-03-10 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D145809#4185320 , @asb wrote: > The change itself looks good to me, but we have the same issue for D and > Zdinx as well. D implies F and Zdinx implies Zfinx so it should still trigger this error. I can add a test? Re

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

2023-03-10 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. The change itself looks good to me, but we have the same issue for D and Zdinx as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145809/new/ https://reviews.llvm.org/D145809 __

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

2023-03-10 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: reames, jrtc27, kito-cheng, asb. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,