[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

aaron.ballman added a comment. In D145671#4223674 , @Pierre-vh wrote: > In D145671#4223655 , @c wrote: > >> These changes need a release note. Given that this has been deprecated, is >> there documentation that s

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

Pierre-vh added a comment. In D145671#4223655 , @c wrote: > These changes need a release note. Given that this has been deprecated, is > there documentation that should have been removed as well? I can't find anything in the docs about `code-object-v3`

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

aaron.ballman added a comment. These changes need a release note. Given that this has been deprecated, is there documentation that should have been removed as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https://reviews.llvm.org

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

This revision was automatically updated to reflect the committed changes. Closed by commit rG30e7cd48778b: [clang] Remove legacy -m(no)-code-object-v3 options (authored by Pierre-vh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https:/

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

Pierre-vh added a comment. I'll wait a couple of more days and then land, if no one has any objections. As said before this has been deprecated for a long time, and clang was already warning on use of those options. Removal has been pending for a while :) Repository: rG LLVM Github Monorepo

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https://reviews.llvm.org/D145671 __

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

kzhuravl added a comment. In D145671#4181568 , @yaxunl wrote: > Did you go through the deprecation process for this option? We need to send a > documentation team first so that it is announced to the users. Then in the > next release we can deprecate it

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

yaxunl requested changes to this revision. yaxunl added a comment. This revision now requires changes to proceed. Did you go through the deprecation process for this option? We need to send a documentation team first so that it is announced to the users. Then in the next release we can deprecate

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

artem.tamazov accepted this revision as: artem.tamazov. artem.tamazov added a comment. This revision is now accepted and ready to land. No objections from MIOpen side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https://reviews.llvm.o

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

Pierre-vh created this revision. Pierre-vh added reviewers: arsenm, foad, kzhuravl, rampitec. Herald added subscribers: kosarev, StephenFan, kerbowa, jvesely. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald added