This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG96cc2d07e15a: [clang] Add AVR specific inline assembly
escaped characters (authored by benshi001).
Repository:
rG LLVM Github Monorepo
CHANGES SI
jacquesguan accepted this revision.
jacquesguan added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145659/new/
https://reviews.llvm.org/D145659
___
cfe-commits mailing list
cf
benshi001 marked an inline comment as done.
benshi001 added inline comments.
Comment at: clang/lib/Basic/Targets/AVR.cpp:433
+AVRTargetInfo::handleAsmEscapedChar(char EscChar) const {
+ char C;
+ switch (EscChar) {
jacquesguan wrote:
> redundant variable?
Remov
benshi001 updated this revision to Diff 504631.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145659/new/
https://reviews.llvm.org/D145659
Files:
clang/lib/Basic/Targets/AVR.cpp
clang/lib/Basic/Targets/AVR.h
clang/test/CodeGen/avr/avr-inline-asm-constraints.c
Index: clang/test/Co
jacquesguan added inline comments.
Comment at: clang/lib/Basic/Targets/AVR.cpp:433
+AVRTargetInfo::handleAsmEscapedChar(char EscChar) const {
+ char C;
+ switch (EscChar) {
redundant variable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
benshi001 created this revision.
benshi001 added reviewers: jacquesguan, aykevl.
Herald added subscribers: Jim, dylanmckay.
Herald added a project: All.
benshi001 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm
