[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-22 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D145646#4213975 , @MaskRay wrote: > In D145646#4213547 , @gulfem wrote: > >> We started seeing a test failure in `avr-ld.c`. >> >> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-22 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem added a comment. In D145646#4213975 , @MaskRay wrote: > In D145646#4213547 , @gulfem wrote: > >> We started seeing a test failure in `avr-ld.c`. >> >> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D145646#4213547 , @gulfem wrote: > We started seeing a test failure in `avr-ld.c`. > > /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr-ld.c:48:11: error: > // LINKP: {{".*ld.*"}} {{.*}} "--defsym=__DATA_REGION_ORIGIN

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-22 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem added a comment. We started seeing a test failure in `avr-ld.c`. /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr-ld.c:48:11: error: // LINKP: {{".*ld.*"}} {{.*}} "--defsym=__DATA_REGION_ORIGIN__=0x800100" "-plugin" {{.*}} "-plugin-opt=mcpu=atmega328" ^ :1:1: note:

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-21 Thread Ben Shi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d37efdbc599: [clang][driver] Enable '-flto' on AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D145646?vs=503607&i

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. "Close" seems more appropriate to me as this isn't a bug (previously not an intended use case). Comment at: clang/test/Driver/avr-ld.c:59 +// LINKS: {{".*ld.*"}} {{.*}} "-

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-21 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-15 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-08 Thread Ben Shi via Phabricator via cfe-commits
benshi001 updated this revision to Diff 503607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/avr-ld.c

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

2023-03-08 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, inglorion, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes http