[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

2023-03-24 Thread Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6fd1b704c0: [libc] Add support for setjmp and longjmp in riscv (authored by Mikhail R. Gadelha ). Repository: rG LLVM Github

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

2023-03-24 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho updated this revision to Diff 508187. mikhail.ramalho added a comment. Update return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145584/new/ https://reviews.llvm.org/D145584 Files: clang/docs/tools/clang-formatted-files.txt l

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

2023-03-24 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho added inline comments. Comment at: libc/src/setjmp/riscv64/longjmp.cpp:54-55 + + LIBC_INLINE_ASM("seqz %0, %1" : "+r"(buf) : "r"(val) :); + LIBC_INLINE_ASM("add %0, %0, %1" : "+r"(buf) : "r"(val), "r"(buf) :); +} sivachandra wrote: > Your commen

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

2023-03-24 Thread Siva Chandra via Phabricator via cfe-commits
sivachandra accepted this revision. sivachandra added inline comments. This revision is now accepted and ready to land. Comment at: libc/src/setjmp/riscv64/longjmp.cpp:54-55 + + LIBC_INLINE_ASM("seqz %0, %1" : "+r"(buf) : "r"(val) :); + LIBC_INLINE_ASM("add %0, %0, %1" : "+r"(b

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

2023-03-23 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho added inline comments. Comment at: libc/src/setjmp/riscv64/longjmp.h:56 + + LIBC_INLINE_ASM("seqz %0, %1" : "+r"(buf) : "r"(val) :); + LIBC_INLINE_ASM("add %0, %0, %1" : "+r"(buf) : "r"(val), "r"(buf) :); sivachandra wrote: > Why is this require

[PATCH] D145584: [libc] Add support for setjmp and longjmp in riscv

2023-03-23 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho updated this revision to Diff 507700. mikhail.ramalho marked 6 inline comments as done. mikhail.ramalho added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http