Fznamznon added a comment.
Filed https://github.com/llvm/llvm-project/issues/61243 to backport.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145486/new/
https://reviews.llvm.org/D145486
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaf682f0df83f: [clang] Fix single-element array
initialization in constexpr (authored by Fznamznon).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145486/new/
Fznamznon updated this revision to Diff 503020.
Fznamznon added a comment.
Rebase and update test comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145486/new/
https://reviews.llvm.org/D145486
Files:
clang/lib/AST/ExprConstant.cpp
clang/t
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for this! Please be sure to file an issue to backport this to
the 16.x branch
(https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches).
==
Fznamznon updated this revision to Diff 502992.
Fznamznon added a comment.
Check FinalSize instead of N since it is probably more obvious
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145486/new/
https://reviews.llvm.org/D145486
Files:
clang/lib
Fznamznon created this revision.
Herald added a project: All.
Fznamznon requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
https://reviews.llvm.org/D130791 added an improvement that in case array
element has a trivial constructor, it is evalua