[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

2023-03-14 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Apologies for late review. Comment at: clang/lib/Sema/SemaStmt.cpp:4405 ASTContext &Ctx; - const llvm::DenseMap &TypesToCheck; - const bool CheckAgainstPointer; + const llvm::DenseMap &TypesToCheck; Can we just make `llvm::DenseM

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

2023-03-14 Thread Aaron Ballman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0950332e91df: Fix false positive with unreachable C++ catch handlers (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.or

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

2023-03-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145408/new/ https://reviews.llvm.org/D145408 ___ cfe-commits mailing list

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

2023-03-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:186 + `#61177 `_ in anticipation + of `CWG2699 _` being accepted by WG21.

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

2023-03-06 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:186 + `#61177 `_ in anticipation + of `CWG2699 _` being accepted by WG21. This link seems broken? I get 40

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

2023-03-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, shafik, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This addresses an issue found by WG21 and tracked by CWG2699 (which is not yet pu