This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6aa74ae29ffc: [HIP] Supports env var HIP_PATH (authored by
yaxunl).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.o
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145391/new/
https://reviews.llvm.org/D145391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 505133.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
fix tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145391/new/
https://reviews.llvm.org/D145391
Files:
clang/lib/Driver/ToolChains/AMDGPU.cpp
clang/test/Driver/rocm-de
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:442
+ llvm::sys::Process::GetEnv("HIP_PATH")) {
+if (!HIPPathEnv->empty()) {
+ HIPSearchDirs.emplace_back(std::move(*HIPPathEnv));
MaskRay added inline comments.
Comment at: clang/test/Driver/rocm-detect.hip:42
+
+// RUN: rm -rf %T/myhip
+// RUN: rm -rf %T/myhip_nouse
`%T` is not recommended.
https://llvm.org/docs/CommandGuide/lit.html
"parent directory of %t (not unique, deprecated, do not
tra added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:442
+ llvm::sys::Process::GetEnv("HIP_PATH")) {
+if (!HIPPathEnv->empty()) {
+ HIPSearchDirs.emplace_back(std::move(*HIPPathEnv));
Style nit. Single-statement if
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: kosarev, kerbowa, jvesely.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: MaskRay.
Currently HIP toolchain recognize env var ROCM_PATH and option --rocm-path
but
