[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

2023-03-06 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb2897ad70301: [include-cleaner] Fix a crash on non-identifier-name symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145364/new/

[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

2023-03-06 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! Comment at: clang-tools-extra/include-cleaner/test/nocrash.cpp:1 +// RUN: clang-include-cleaner %s -- + hokein wrote: > I have considered t

[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

2023-03-06 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/test/nocrash.cpp:1 +// RUN: clang-include-cleaner %s -- + I have considered to add a unittest in `FindHeadersTest`, but that is not trivial to do, the unittest is written based on the as

[PATCH] D145364: [include-cleaner] Fix a crash on non-identifier-name symbols.

2023-03-06 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145364 Files: clang-tools-extra/include-cleaner/lib