[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. We can’t let specific flag usage leak into the semantics. Cu mode is on or off. If someone really cares about supporting older compilers they could always define their own macro CH

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

tra added a comment. Can `__has_feature` be used to accomplish what you need? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145343/new/ https://reviews.llvm.org/D145343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

b-sumner added a comment. In D145343#4170305 , @yaxunl wrote: > In D145343#4170250 , @arsenm wrote: > >> I think exposing whether or not the flag was used is weird/broken, as is >> including _OPTION in the name.

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

yaxunl added a comment. In D145343#4170250 , @arsenm wrote: > I think exposing whether or not the flag was used is weird/broken, as is > including _OPTION in the name. Should just define to whether it's enabled or > not I agree. @b-sumner What do you t

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

arsenm added a comment. I think exposing whether or not the flag was used is weird/broken, as is including _OPTION in the name. Should just define to whether it's enabled or not CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145343/new/ https://reviews.llvm.org/D145343

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

yaxunl created this revision. yaxunl added reviewers: tra, b-sumner, arsenm. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: wdng. Predefine `__AMDGCN_CUMODE_OPTION` as