[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

aaron.ballman added a comment. @cjdb -- how would you like to proceed with this review? There's already quite a bit of discussion on the current Phab patch set, but it seems unlikely that we'd be able to wrap everything up by the Nov 15th deadline. But then again, GitHub has no ability to do st

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

kolrami added a comment. Hi @cjdb , I would be interested in this change also since GCC supports the same sarif-stderr and sarif-file options. Is there a further plan that it might be integrated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14528

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

vaibhav.y added inline comments. Comment at: clang/lib/Tooling/SarifLinker.cpp:21 + +namespace llvm::sarif_linker { +[[noreturn]] void ReportErrorAndExit(llvm::errc error_code, StringRef Message) { Is this for link diagnostics reported as SARIF? Repository:

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb marked an inline comment as done. cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticOptions.h:110 + /// The file to serialise text diagnostics to (non-appending). + std::string FilePath; + erichkeane wrote: > I'm a touch disturbed

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

erichkeane added a subscriber: jansvoboda11. erichkeane added a comment. Patch topic needs "WIP" out of it I think? Just some WIP comments, I don't believe I'd be the one to approve this anyway. Comment at: clang/include/clang/Basic/DiagnosticOptions.h:109 + /// The file to

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 504309. cjdb added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. merges in D145438 . This patch is ready for review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502308. cjdb added a comment. tidies up some stuff that I overlooked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files: clang/include/clang/Basic/DiagnosticOptions

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 502305. cjdb edited the summary of this revision. cjdb added a comment. adds dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145284/new/ https://reviews.llvm.org/D145284 Files: clang/include/clang/Basi

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik, dblaikie. Herald added a project: All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The original `-fdiagnostics-format=sarif` wrote directl