[PATCH] D145262: [clang-format] Treat AttributeMacros more like __attribute__

2023-10-15 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6f46bcc609f1: [clang-format] Treat AttributeMacro more like __attribute__ (authored by jaredgrubb, committed by owenpan). Changed prior to commit: https://reviews.llvm.org/D145262?vs=557674&id=557707#to

[PATCH] D145262: [clang-format] Treat AttributeMacros more like __attribute__

2023-10-15 Thread Jared Grubb via Phabricator via cfe-commits
jaredgrubb added a comment. In D145262#4653670 , @owenpan wrote: > @jaredgrubb please provide your authorship for `git commit --author` so that > we can land the patch on your behalf. The best to use would be: Jared Grubb Thanks so much for your he

[PATCH] D145262: [clang-format] Treat AttributeMacros more like __attribute__

2023-10-10 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. @jaredgrubb please provide your authorship for `git commit --author` so that we can land the patch on your behalf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://reviews.llvm.org/D145262 ___ cfe-co

[PATCH] D145262: [clang-format] Treat AttributeMacros more like __attribute__

2023-10-10 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://reviews.llvm.org/D145262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D145262: [clang-format] Treat AttributeMacros more like __attribute__

2023-10-10 Thread Jared Grubb via Phabricator via cfe-commits
jaredgrubb updated this revision to Diff 557674. jaredgrubb added a comment. Addressed review feedback from Oct2 (@owenpan). A new issue on Github was opened for this enhancement (https://github.com/llvm/llvm-project/issues/68722) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new

[PATCH] D145262: [clang-format] Treat AttributeMacros more like __attribute__

2023-10-02 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. Can you add a github issue to show the behavior before this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://reviews.llvm.org/D145262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt