[PATCH] D145238: [NVPTX] Expose LDU builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7258317bade0: [NVPTX] Expose LDU builtins (authored by jchlanda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 505394. jchlanda added a comment. Use `CHECK-LABEL`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a test nit. Comment at: llvm/test/CodeGen/NVPTX/ldu-ldg.ll:30 +; CHECK: test_ldu_i16 +define i16 @test_ldu_i16(ptr addrspace(1) %ptr) { Nit. Function n

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda marked an inline comment as done. jchlanda added a comment. @tra is there anything else I should do for this patch? Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda marked 5 inline comments as done. jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.seco

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 503644. jchlanda added a comment. `append` -> `+` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/Co

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.second.append(" requires native half type support."

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.second.append(" requires native half type supp

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 503242. jchlanda added a comment. Simplify the check for half tys support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files: clang/include/clang/Basic/Builtin

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18267-18271 +auto HalfSupport = HasHalfSupport(BuiltinID); +if (!HalfSupport.first) { + CGM.Error(E->getExprLoc(), +HalfSupport.second.append(" requires native half type support."

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18116 +case NVPTX::BI__nvvm_ldu_h: + BuiltinName = "__nvvm_ldu_h"; + break; tra wrote: > Can we use the standard `StringRef Name = > getContext().BuiltinInfo.getName(Builti

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda updated this revision to Diff 502948. jchlanda marked 3 inline comments as done. jchlanda added a comment. Address PR comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238 Files: clang/inclu

[PATCH] D145238: [NVPTX] Expose LDU builtins

tra added a comment. Nice. Thank you! Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18104 CodeGenFunction::EmitNVPTXBuiltinExpr(unsigned BuiltinID, const CallExpr *E) { - auto MakeLdg = [&](unsigned IntrinsicID) { + auto HasHalfSupport = [&](unsigned BuiltinID) { +auto &Co

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda created this revision. jchlanda added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jholewinski. Herald added projects: clang, LLVM. Al