[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. nvm i found the file in one of the previous commits. https://github.com/llvm/llvm-project/pull/68735 for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. @alexfanqi can you please upload the file (tsan_rtl_riscv64.S) with the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cf

[PATCH] D145214: [TSAN] add support for riscv64

haowei added a comment. Hi, I believe you forgot to add `tsan_rtl_riscv64.S` to your patch when you land it. We are seeing build errors on our bots with following messages: -- Configuring done (12.3s) CMake Error at /b/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cm

[PATCH] D145214: [TSAN] add support for riscv64

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0a8245b0fe: add support for riscv64 (authored by alexfanqi, committed by AdityaK <1894981+hiradi...@users.noreply.github.com>). Changed prior to commit: https://reviews.llvm.org/D145214?vs=557362&id=

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larg

[PATCH] D145214: [TSAN] add support for riscv64

jrtc27 added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larg

[PATCH] D145214: [TSAN] add support for riscv64

dvyukov accepted this revision. dvyukov added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. Another test that failed: compiler-rt/test/tsan/signal_thread.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cfe-commits mai

[PATCH] D145214: [TSAN] add support for riscv64

MaskRay accepted this revision. MaskRay added a comment. Other than -Wframe-larger-than=656 and `const uptr indicator = 0x0f00ull;` changes, others looks good to me. I agree that this should be reviewed by @dvyukov :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D145214: [TSAN] add support for riscv64

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SAN

[PATCH] D145214: [TSAN] add support for riscv64

MaskRay added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform.h:971 }; -const uptr indicator = 0x0e00ull; +const uptr indicator = 0x0f00ull; const uptr ind_lsb = 1ull << LeastSignificantSetBitIndex(indicator);

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added a comment. >> While testing compiler-rt/test/tsan/RISCV64Config only >> compiler-rt/test/tsan/mmap_lots.cpp failed. I couldn't run all the >> compiler-rt tests on Licheepi because it is very slow I had this only test failure before. When the upper memory space is fully mapped o

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. In D145214#4650928 , @alexfanqi wrote: > In D145214#4650189 , @hiraditya > wrote: > >> I tested it on a licheepi board (riscv64 debian) and all the tests modified >> in this patch have

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added a comment. In D145214#4650189 , @hiraditya wrote: > I tested it on a licheepi board (riscv64 debian) and all the tests modified > in this patch have passed. LGTM. Can you help me land this patch? > There are other tsan failures but i th

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi updated this revision to Diff 557362. alexfanqi added a comment. thanks @hiraditya Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-rt/cm

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. I tested it on a licheepi board (riscv64 debian) and all the tests passed. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:223 +elseif(arch MATCHES "riscv64") + add_asm_sources(TSAN_ASM_SOURCES +tsan_rtl_riscv64.S hiraditya wrote: > I'm getting error with this line for some reason. U

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:223 +elseif(arch MATCHES "riscv64") + add_asm_sources(TSAN_ASM_SOURCES +tsan_rtl_riscv64.S I'm getting error with this line for some reason. Unknown cmake comman

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. ping: @jrtc27 @asb do you have any pending feedback for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cfe-commits m

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added a comment. In D145214#4646676 , @hiraditya wrote: > @alexfanqi are you still actively working on this? maybe we can move it to > github then. Yeah, but the patch is already complete and tsan functions well with tests passing on my local

[PATCH] D145214: [TSAN] add support for riscv64

hiraditya added a comment. Herald added subscribers: wangpc, sunshaoce. @alexfanqi are you still actively working on this? maybe we can move it to github then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added a comment. friendly ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform.h:971 }; -const uptr indicator = 0x0e00ull; +const uptr indicator = 0x0f00ull; const uptr ind_lsb = 1ull << LeastSignificantSetBitIndex(indicator); --

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi updated this revision to Diff 502397. alexfanqi added a comment. remove libatomic link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-r

[PATCH] D145214: [TSAN] add support for riscv64

jrtc27 added inline comments. Comment at: compiler-rt/CMakeLists.txt:529 # natively, but supports --as-needed/--no-as-needed for GNU ld compatibility. -if("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc") +if("${COMPILER_RT_DEFAULT_TARGET_ARCH}" MATCHES "sparc|riscv") lis

[PATCH] D145214: [TSAN] add support for riscv64

alexfanqi created this revision. Herald added subscribers: luke, Enna1, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosH