[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm closed this revision. arsenm added a comment. dd8181055494d8f973dfaaba282bb1ae6eab4d40 Comment at: clang/lib/CodeGen/CGCall.cpp:3052 +AI->addAttrs( +llvm::AttrBuilder(getLLVMContex

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 ___ cfe-commits mailing list cfe-commi

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm updated this revision to Diff 505253. arsenm marked an inline comment as done. arsenm added a comment. Drop unnecessary part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/comp

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

efriedma added a comment. Looks fine from a codegen perspective, assuming these are the semantics we want for -ffinite-math-only. Comment at: clang/lib/CodeGen/CGCall.cpp:3052 +AI->addAttrs( +llvm::AttrBuilder(getLLVMContext()).addNoFPClassAttr(Mask)); +

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

tra added a subscriber: nikic. tra added a comment. I'm in the same boat as @nikic -- the patch looks reasonable in principle, but I'm not familiar with the nuanaces of FP codegen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 _

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

jcranmer-intel added a comment. I'm generally okay with the approach of this patch. I'm not sufficiently well-versed in the clang codegen side of things to know if this covers all of the bases, and I'd appreciate someone who is familiar with that side of things to approve this patch. CHANGES

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

nikic resigned from this revision. nikic added a comment. (Sounds reasonable conceptually, but I'm not familiar enough with clang codegen for the details.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 __

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm updated this revision to Diff 502015. arsenm added a comment. Drop todo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145150/new/ https://reviews.llvm.org/D145150 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/complex-math.c clang/test/CodeGen/fp-function-attrs.cpp

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

jcranmer-intel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2212 +static llvm::FPClassTest getNoFPClassTestMask(const LangOptions &LangOpts) { + // TODO: Handle -fno-signaling-nans + llvm::FPClassTest Mask = llvm::fcNone; Clang doesn't have s

[PATCH] D145150: clang: Emit nofpclass(nan inf) for -ffinite-math-only

arsenm created this revision. arsenm added reviewers: efriedma, nikic, jcranmer-intel, kpn, andrew.w.kaylor, cameron.mcinally, sepavloff. Herald added subscribers: StephenFan, jdoerfert, hiraditya. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: llv