[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

2023-03-02 Thread Stephan Bergmann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd812488d3c54: Call MarkVirtualMembersReferenced on an actual class definition (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D145123?vs=501669&id=501852#toc Repository: rG LLV

[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

2023-03-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks! LGTM, though please add a release note about the fix. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:17940 LoadExternalVTableUses(); Class = Class->ge

[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

2023-03-01 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:17940 LoadExternalVTableUses(); Class = Class->getCanonicalDecl(); std::pair::iterator, bool> That call of `getCanonicalDecl` originated with

[PATCH] D145123: Call MarkVirtualMembersReferenced on an actual class definition

2023-03-01 Thread Stephan Bergmann via Phabricator via cfe-commits
sberg created this revision. sberg added reviewers: doug.gregor, aaron.ballman. sberg added a project: clang. Herald added a project: All. sberg requested review of this revision. ...rather than on potentially just a declaration. Without the fix, the newly added `clang/test/SemaCXX/warn-undefined