[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

Jake-Egan added a comment. Thanks for addressing this. Unfortunately the test is still failing after the fix and a clean build https://lab.llvm.org/buildbot/#/builders/214/builds/6170/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 added a comment. In D145098#4167163 , @Jake-Egan wrote: > Hi, this new test fails on AIX, could you take a look please? > https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c `-fno

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

Jake-Egan added a comment. Hi, this new test fails on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

This revision was automatically updated to reflect the committed changes. Closed by commit rG864054500830: [clang][deps] Preserve input ordering in the full output (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145098/new/

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:788 + if (Format == ScanningOutputFormat::Full && ModuleName.empty()) +FD.resize(Inputs.size()); + benlangmuir wrote:

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 updated this revision to Diff 501619. jansvoboda11 added a comment. Add asserts, make `FullDeps` take `NumInputs` in the constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145098/new/ https://reviews.llvm.org/D145098 Files:

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

benlangmuir added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:291 -std::unique_lock ul(Lock); -Inputs.push_back(std::move(ID)); +Inputs[InputIndex] = std::move(ID); } Since the input index is coming from "outside":

[PATCH] D145098: [clang][deps] Preserve input ordering in the full output

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added subscribers: ributzka, mgrang. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes