[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

This revision was automatically updated to reflect the committed changes. kpdev42 marked an inline comment as done. Closed by commit rG21cd04c46fe0: [clang][ASTImport] Add support for import of empty records (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. There are some unresolved comments in the test (cast is not needed at `Import` and `EXPECT_TRUE` can be used) but otherwise LGTM. (But I have a feeling that problems may happen with attribu

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1171 + /// attribute + void markEmpty() { data().Empty = true; } balazske wrote: > This change looks not related. The `markEmpty` is still n

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 updated this revision to Diff 504956. kpdev42 marked an inline comment as done. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145057/new/ https://reviews.llvm.org/D145057 Files: clang/incl

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1171 + /// attribute + void markEmpty() { data().Empty = true; } This change looks not related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3897 + if (Err) +return std::move(Err); ToField->setAccess(D->getAccess()); kpdev42 wrote: > balazske wrote: > > I am not familiar with this use case, is there a path where the attr

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked 2 inline comments as done. kpdev42 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8161 +EXPECT_EQ(true, FD->hasAttr()); +} + balazske wrote: > Does this test fail without the changes applied? And does it not fail aft

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3897 + if (Err) +return std::move(Err); ToField->setAccess(D->getAccess()); balazske wrote: > I am not familiar with this use case, is there

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3897 + if (Err) +return std::move(Err); ToField->setAccess(D->getAccess()); I am not familiar with this use case, is there a path where the attributes are read from a `FieldDecl` b

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 created this revision. kpdev42 added reviewers: clayborg, balazske. kpdev42 added a project: LLVM. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. kpdev42 requested review of this revision. Herald added a project: clang. Herald added a subsc