ashay-github added a comment.
> For pure test updates, best to include `[test] `in the subject :)
Ah, sorry! Thanks for letting me know, I'll keep that in mind for the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144934/new/
https://revi
MaskRay added a comment.
For pure test updates, best to include `[test] `in the subject :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144934/new/
https://reviews.llvm.org/D144934
___
cfe-commits maili
This revision was automatically updated to reflect the committed changes.
Closed by commit rG969ab7134f4d: [clang] drop buggy use of
`-serialize-diagnostics` flag (authored by ashay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144934/new/
https:/
ashay-github updated this revision to Diff 501516.
ashay-github added a comment.
Rebased with main branch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144934/new/
https://reviews.llvm.org/D144934
Files:
clang/test/ClangScanDeps/P1689.cppm
In
ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144934/new/
https://reviews.llvm.org/D144934
__
ashay-github created this revision.
ashay-github added reviewers: ChuanqiXu, jansvoboda11, ben.boeckel.
Herald added a project: All.
ashay-github requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The `-serialize-diagnostics` flag requires a f
