[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. Since `llc` has `-mcpu=help`, it seems fine to have `clang -mcpu=help`. I made a bad suggestion there about `-mcpu=?`. Perhaps I should revert de94ac9357750fdba45e09eefa8f67a650ae6a64 . This `-mcpu=help` patch is good. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland added a comment. In D144914#4159291 , @MaskRay wrote: > Sorry I just saw this but I am not sure this is a good idea. Why can't the > user use `--print-supported-cpus` instead? The additional alias doesn't seem > useful. If you can make G

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. FWIW I think this should be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. Sorry I just saw this but I am not sure this is a good idea. Why can't the user use `--print-supported-cpus` instead? The additional alias doesn't seem useful. If you can make GCC add this as well, it will be different. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG003078b62d8d: [Clang][Driver] Add -mcpu=help and -mtune=help to clang (authored by michaelmaitland). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914 ___

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland added a comment. In D144914#4156567 , @reames wrote: > Code and description appear out of sync. (help != list) Personally, I like > the help naming a lot better. Thanks for catching this. I meant to write `help` instead of `list`. Re

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland updated this revision to Diff 500907. michaelmaitland added a comment. Change `list` -> `help`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914 Files: clang/docs/CommandGuide/clang.rst

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

reames added a comment. Code and description appear out of sync. (help != list) Personally, I like the help naming a lot better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland created this revision. michaelmaitland added reviewers: craig.topper, reames. Herald added a project: All. michaelmaitland requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang currently uses `-mcpu=?`. The `?` causes errors