This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG047273fc9c84: [clang-tidy] Add bugprone-empty-catch check
(authored by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
PiotrZSL updated this revision to Diff 543314.
PiotrZSL added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Add -fexceptions to tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf256fee53430: [clang-tidy] Add bugprone-empty-catch check
(authored by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.
xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.
LGTM, but we can wait for a couple of before committing in case other reviewers
have more review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
PiotrZSL updated this revision to Diff 543276.
PiotrZSL marked 3 inline comments as done.
PiotrZSL added a comment.
Rebase (release notes)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.llvm.org/D144748
Files:
clang-to
PiotrZSL marked 3 inline comments as done.
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:71
+
+bool EmptyCatchCheck::isLanguageVersionSupported(
+const LangOptions &LangOpts) const {
xgupta wrote:
> This
xgupta added a comment.
Other than these three points everything looks good to me.
Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:71
+
+bool EmptyCatchCheck::isLanguageVersionSupported(
+const LangOptions &LangOpts) const {
This can b
PiotrZSL added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.llvm.org/D144748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
PiotrZSL added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.llvm.org/D144748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
PiotrZSL updated this revision to Diff 514000.
PiotrZSL added a comment.
Add getCheckTraversalKind, format tests, fix some review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.llvm.org/D144748
Files:
clang-to
PiotrZSL marked 4 inline comments as done.
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:147-153
+.. option:: IgnoreCatchWithKeywords
+
+This option can be used to ignore specific catch statements containing
+
PiotrZSL marked an inline comment as done.
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:100
+void EmptyCatchCheck::check(const MatchFinder::MatchResult &Result) {
+ const auto *MatchedCatchStmt = Result.Nodes.getNodeAs("ca
PiotrZSL marked an inline comment as done.
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:100
+void EmptyCatchCheck::check(const MatchFinder::MatchResult &Result) {
+ const auto *MatchedCatchStmt = Result.Nodes.getNodeAs("ca
carlosgalvezp added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:103
+{
+try
+{
Use 2 spaces indentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
carlosgalvezp added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:100
+void EmptyCatchCheck::check(const MatchFinder::MatchResult &Result) {
+ const auto *MatchedCatchStmt = Result.Nodes.getNodeAs("catch");
+
Assert that
PiotrZSL updated this revision to Diff 503365.
PiotrZSL added a comment.
Ping, Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.llvm.org/D144748
Files:
clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
PiotrZSL updated this revision to Diff 500274.
PiotrZSL added a comment.
Fix review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144748/new/
https://reviews.llvm.org/D144748
Files:
clang-tools-extra/clang-tidy/bugprone/BugproneTidyModu
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:169
+should be provided. If an exception type name in the list is caught in an
+empty catch statement, no warning will be raised. Default value: ``
(empty
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone/empty-catch.rst:169
+should be provided. If an exception type name in the list is caught in an
+empty catch statement, no warning will be raised. Default value: ``
(empty).
---
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp:77
+void EmptyCatchCheck::registerMatchers(MatchFinder *Finder) {
+
+ auto AllowedNamedExceptionDecl =
Excessive newline.
Comment at:
PiotrZSL created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Detects and suggests ad
21 matches
Mail list logo
