[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

2023-02-24 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4416e4a9ed06: [Tooling/Inclusion] Add the generic abs symbol to the table. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

2023-02-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oh right, i thought these were also provided by multiple headers, but looks like they're only provided by `cstdlib`, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

2023-02-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D144721#4150122 , @kadircet wrote: > this fixes the `abs` in the mentioned issue, but leaves the friends out :( > those are specifically `std::labs, std::llabs, std::imaxabs` These symbols are already covered in the generated

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

2023-02-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. this fixes the `abs` in the mentioned issue, but leaves the friends out :( those are specifically `std::labs, std::llabs, std::imaxabs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144721/new/ https://reviews.llvm.org/D1

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

2023-02-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/60964 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144721