[PATCH] D144709: [clang-format] Improve QualifierAlignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7ab4b5c168: [clang-format] Improve QualifierAlignment (authored by AlexanderHederstaf, committed by MyDeveloperDay). Changed prior to commit: ht

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. Okay thanks. If the + options works let's go with alexanderhederstaf+l...@gmail.com Thanks again for the review and answers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D14

[PATCH] D144709: [clang-format] Improve QualifierAlignment

HazardyKnusperkeks added a comment. In D144709#4196738 , @AlexanderHederstaf wrote: > In D144709#4193603 , > @MyDeveloperDay wrote: > >> In D144709#4188921 , >> @Alexan

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. In D144709#4193603 , @MyDeveloperDay wrote: > In D144709#4188921 , > @AlexanderHederstaf wrote: > >> What is the next step in the process? Anything I should do? > > If you hav

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. In D144709#4188921 , @AlexanderHederstaf wrote: > What is the next step in the process? Anything I should do? If you have commit access you can go ahead and commit, if not and you want one of us to do it, we need your na

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. What is the next step in the process? Anything I should do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 ___ cfe-commits

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf requested review of this revision. AlexanderHederstaf added a comment. Refactored using the NonComment() functions and added some tests to verify that it works correctly. In D144709#4171029 , @MyDeveloperDay wrote: > I might have bee

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I might have been tempted to handle the comments in a separate commit, I don't like to do too much in one go or the review gets hard to manage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 502563. AlexanderHederstaf added a comment. This revision is now accepted and ready to land. Handle /*c*/ comments inside types. Add >> test to right->left. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf planned changes to this revision. AlexanderHederstaf added a comment. Missed right->left in the fix. Also looking a bit at comments, e.g. ns::/*ns2::*/vector v; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https:/

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 502545. AlexanderHederstaf added a comment. Add extra tests based on https://github.com/llvm/llvm-project/issues/56111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.o

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;", Style); + AlexanderHederstaf wrot

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:733 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, const Foo >> ;", "Bar < Foo, Foo const >> ;", Style); + rymiel wrot

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. In D144709#4169219 , @rymiel wrote: > This patch also fixes: https://github.com/llvm/llvm-project/issues/56111, > https://github.com/llvm/llvm-project/issues/58696, and > https://github.com/llvm/llvm-project/issues/54730

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:523 + // TODO: Something strange is going on with this formating. + verifyFormat("Bar < Foo, Foo const >> ;", "Bar < Foo, const Foo >> ;", Style); + (see below) =

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added a comment. This patch also fixes: https://github.com/llvm/llvm-project/issues/56111, https://github.com/llvm/llvm-project/issues/58696, and https://github.com/llvm/llvm-project/issues/54730 (some of those could probably be made duplicates but it seems they're all going down in one

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. Thanks for the comments and help on this review. There are a lot of special cases I had not considered before, and while it works on the clang/ and llvm/ subfolders as well as tests and the other repository I tested on, I suppose there could still be some hid

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Firstly let me say thank you for this review, your perseverance demonstrates to me that there is a desire to make this capability better, which tells me that a feature that ult

[PATCH] D144709: [clang-format] Improve QualifierAlignment

HazardyKnusperkeks added a comment. In D144709#4160940 , @AlexanderHederstaf wrote: > In D144709#4160820 , > @MyDeveloperDay wrote: > >> As tests currently fail can you set it to "planned changes" until they pas

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. In D144709#4160939 , @AlexanderHederstaf wrote: > This code from llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp failed > with **Right** but without a full list of specifiers. As **static** was not > configur

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 501476. AlexanderHederstaf added a comment. Change order for typename and :: as const typename ::Bar b; is valid code. Add code for handling ::template. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. In D144709#4160820 , @MyDeveloperDay wrote: > As tests currently fail can you set it to "planned changes" until they pass > > [ FAILED ] 5 tests, listed below: > [ FAILED ] QualifierFixerTest.RightQualifier >

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. This code from llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp failed with **Right** but without a full list of specifiers. As **static** was not configured, the } was not discovered by **IsRightQualifier**. Changed some of the qualifier tests to chec

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 501420. AlexanderHederstaf added a comment. Distinguish configured qualifiers from other qualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files:

[PATCH] D144709: [clang-format] Improve QualifierAlignment

MyDeveloperDay added a comment. As tests currently fail can you set it to "planned changes" until they pass [ FAILED ] 5 tests, listed below: [ FAILED ] QualifierFixerTest.RightQualifier [ FAILED ] QualifierFixerTest.LeftQualifier [ FAILED ] QualifierFixerTest.ConstVolatileQualifi

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added a comment. In D144709#4158555 , @AlexanderHederstaf wrote: > Discovered incorrect code generation for `llvm/include/llvm/ADT/StringMap.h`. > > using base = StringMapIterBase, > const StringMapEntry>; > > w

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. Discovered incorrect code generation for `llvm/include/llvm/ADT/StringMap.h`. using base = StringMapIterBase, const StringMapEntry>; was converted to, removing two characters. I checked the Token length in InsertQualifierAf

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 501137. AlexanderHederstaf added a comment. Simplify insertQualifierAfter. Ignore decltype, typeof, and _Atomic. Set length of TT_TemplateCloser to 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 500799. AlexanderHederstaf added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files: clang/lib/Format/QualifierAlignm