[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

2023-02-24 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc4972d37290f: [clangd] Avoid using CompletionItemKind.Text for macro completions (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/n

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

2023-02-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks an improvement to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/new/ https://reviews.llvm.org/D144703 ___

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

2023-02-24 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 500087. nridge added a comment. use Constant rather than Variable for object-like macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/new/ https://reviews.llvm.org/D144703 Files: clang-tools-extra/cla

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

2023-02-23 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added reviewers: kadircet, hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https: