[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. I accidentally pushed the old version of this patch in rG524ed4b1ba51 , I've pushed a change to match what was reviewed here in rG78086af43ade

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG524ed4b1ba51: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit: https://reviews.ll

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 _

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. I did some local testing, and this no longer seems to crash for me. Hopefully the bots will be fine too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 _

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. I can check out a copy of this patch and help test it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 511153. john.brawn edited the summary of this revision. john.brawn added a comment. New version that checks for special filenames in ResolveImportedPath. I spent a while trying to come up with a test using just clang where not doing this fails, but couldn

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. I think given Michael's investigation, we'll go ahead and revert. That said, some feedback on his suggestion for: > I wonder if we should just not add the root paths to filenames. Would allows us to make progress in restoring this patch Repository: rG LLVM Github M

[PATCH] D144651: [Serialization] Place command line defines in the correct file

Michael137 added a comment. FWIW here's some info on how we get to the assert. Maybe someone with more understanding of the `clang::SourceManager` and how it interacts with `.pcm`s will be able to spot something. Here's a bit more of the stack trace: frame #41: 0x00013844c7e0 liblldb.17

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman added a comment. In D144651#4219633 , @fdeazeve wrote: > In D144651#4219340 , @aaron.ballman > wrote: > >> The build lab's lldb builders are all green, and greendragon's standalone >> build is also

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. In D144651#4219340 , @aaron.ballman wrote: > In D144651#4217750 , @john.brawn > wrote: > >> Unfortunately I still can't reproduce this even using exactly the same cmake >> command as y

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman added a comment. In D144651#4217750 , @john.brawn wrote: > Unfortunately I still can't reproduce this even using exactly the same cmake > command as you gave. Looking at above cmake log some possible causes of > difference are: > > - I'm

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Unfortunately I still can't reproduce this even using exactly the same cmake command as you gave. Looking at above cmake log some possible causes of difference are: - I'm doing this on an M1 macbook with host triple arm64-apple-darwin21

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. > It looks like green.lab.llvm.org is down, so can't look at that log, but > doing a local build and test of lldb (on a macbook, as this test is only > enabled on macos) I don't see this failure, or any other tests failing with > this assertion. It should be back onli

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. In D144651#4210787 , @fdeazeve wrote: > According to git-bisect, this patch is causing the LLDB bots to crash. > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console > > (They were failing for other reasons b

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. According to git-bisect, this patch is causing the LLDB bots to crash. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console (They were failed for other reasons before, which is why it took a while for this to be identified) Clang is crashing with: `A

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was automatically updated to reflect the committed changes. Closed by commit rG72073fc95cd4: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D144651?vs=502977&id=506642#toc Repository: rG

[PATCH] D144651: [Serialization] Place command line defines in the correct file

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should also add a release note for the fix. Comment at: clang/lib/Serialization/ASTReader.cpp:1593 +if (Record[3]) { + SrcMgr::FileInf

[PATCH] D144651: [Serialization] Place command line defines in the correct file

mstorsjo added a reviewer: aaron.ballman. mstorsjo added a subscriber: aaron.ballman. mstorsjo added a comment. Adding @aaron.ballman as fallback Clang reviewer here. While I did touch code in the vicinity of this area recently, I'm not familiar enough with the whole area to take on reviewing it

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502977. john.brawn added a comment. Ran clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang/lib/Serialization/ASTReader.cpp

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502683. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Herald added a project: clang-tools-extra. Fixed a couple of things causing failures in clangd tests (path being

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn created this revision. john.brawn added reviewers: mstorsjo, jansvoboda11, DHowett-MSFT, sammccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix two problems happening during deseria