[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary planned changes to this revision. lenary added a comment. To be clear: I've not yet addressed @jhenderson's comments above, yet, which may require changes to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://revie

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

jhenderson added a comment. Related to my inline comment, your changes will result in some tests being disabled on Windows that weren't before (at least one of the tests pass for me even on my machine where atime is disabled). I think we need to understand why these tests pass on Windows before

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked an inline comment as done. lenary added a comment. @jhenderson @int3 I think I have addressed your feedback - are you happy for me to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D1446

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 _

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:190 +return False +if "1995" not in touch_res_out: +return False michaelplatings wrote: > This could end up matching the wrong part of the stri

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary updated this revision to Diff 501838. lenary marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 Files: clang/test/Modules/prune.m lld/test/COFF/lto-cache.ll lld/t

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added a comment. In D144638#4155217 , @michaelplatings wrote: > I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not > `UNSUPPORTED: system-windows` - do you know why? I'm not entirely sure why, but I have some ideas: -

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

jhenderson added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err != ""

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

michaelplatings added a comment. I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not `UNSUPPORTED: system-windows` - do you know why? Comment at: llvm/utils/lit/lit/llvm/config.py:190 +return False +if "1995" not in touch_r

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked 2 inline comments as done. lenary added a comment. Hopefully this addresses the feedback so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 _

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary retitled this revision from "[lit] Detect Consistent File Access Times" to "[lit] Detect Inconsistent File Access Times". lenary edited the summary of this revision. lenary updated this revision to Diff 500742. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo