[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err != "": --

[PATCH] D144638: [lit] Detect Consistent File Access Times

michaelplatings added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. Updates incoming to add a specific check for netbsd and windows, which are currently excluding the affected tests anyway. Comment at: llvm/utils/lit/lit/llvm/config.py:165 +# +# This check hopefully detects both cases, and disables tests that re

[PATCH] D144638: [lit] Detect Consistent File Access Times

michaelplatings added a comment. Thanks very much for looking into this, the flakiness of these tests has been bugging me for ages. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_

[PATCH] D144638: [lit] Detect Consistent File Access Times

int3 added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:165 +# +# This check hopefully detects both cases, and disables tests that require +# consistent atime. lenary wrote: > jhenderson wrote: > > Is "hopefully" really needed here?

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. In D144638#4147133 , @jhenderson wrote: > This looks reasonable to me, with the caveat that I don't know a huge amount > about how the different OSes access time systems work. One question though: > if your antivirus was causing

[PATCH] D144638: [lit] Detect Consistent File Access Times

jhenderson added a comment. This looks reasonable to me, with the caveat that I don't know a huge amount about how the different OSes access time systems work. One question though: if your antivirus was causing flakiness (as opposed to outright always-fails), won't it just move that flakiness i

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added reviewers: simonwallis2, mgorny. lenary added a subscriber: mgorny. lenary added a comment. Adding more reviewers. @mgorny you disabled some tests on NetBSD in the past for the same reason (rG92dc7dce4a6f117a497ced1650bc48e5b658f0ea

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary created this revision. Herald added subscribers: pmatos, asb, ormris, steven_wu, delcypher, hiraditya, sbc100, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho. lenary requ