[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

2023-02-28 Thread Ben Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1c112897b202: [clang][driver] Do not emit default '-Tdata' for AVR devices (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D144533?vs=499360&id=501386#toc Repository: rG LL

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

2023-02-28 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D144533#4160297 , @MaskRay wrote: > This change is an improvement but why is `__DATA_REGION_ORIGIN__` defined? Because, 1. Different AVR devices have different SRAM address range (start & length), and `__DATA_REGION_ORIGIN

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

2023-02-28 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. This change is an improvement but why is `__DATA_REGION_ORIGIN__` defined? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144533/new/ https://reviews.llvm.org/D144533 ___ cfe-comm

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

2023-02-21 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. Different AVR device families have different default linker scripts in avr-ld, but they have 95% similarity and look like as following, we can use `--defsym=__DATA_REGION_ORIGIN__` to decide the default data region range instead of current `-Tdata`. /* Script for l

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

2023-02-21 Thread Ben Shi via Phabricator via cfe-commits
benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Different AVR devices