[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added a comment. In D144522#4236636 , @PiotrZSL wrote: > @carlosgalvezp > Thank you, by any chance would you be able to look into other reviews ? Doing my best to catch up, I have a long list of patches to review! Unfortunately very limite

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

cjdb added a comment. Thanks so much for seeing this through; I'm unusually looking forward to rebuilding LLVM this weekend! Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:82 + +.. option:: OverloadedOperators +

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

This revision was automatically updated to reflect the committed changes. Closed by commit rGa084854266ca: [clang-tidy] Add readability-operators-representation check (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D144522?vs=508310&id=510055#toc Repository: rG LLVM

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL added a comment. @carlosgalvezp Thank you, by any chance would you be able to look into other reviews ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 ___

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks for the check! Please fix the missing space comment before landing. Comment at: clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCh

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 508310. PiotrZSL added a comment. Fixes in documentation & clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files: clang-tools-extra/clang-tidy/readabi

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:139 + + Check helps enforce consistent token representation for invoked binary, + unary and overloaded operators in C++ code. Please omit `Check`. Comme

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 508303. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Rebase + Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files: clang-too

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL marked 8 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp:220 + if (!isAnyOperatorEnabled(OverloadedOperators, OperatorsRepresentation) && + isAnyOperatorEnabled(Overload

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added a comment. Looks really good, thank you! I have only very minor comments, mostly style nits and suggestions for improved readability. Comment at: clang-tools-extra/clang-tidy/readability/OperatorsRepresentationCheck.cpp:25 + +StringRef getOperatorSpelling(

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 506398. PiotrZSL added a comment. Update documentation, changed default check configuration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files: clang-tools-ext

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. Update documentation, and config examples, add "Traditional Tokens Representation" section. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:159 +Configuratio

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:16 +To configure the check to enforce the traditional token representation, you can +set the `BinaryOperators` and `OverloadedOperators` options to

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:16 +To configure the check to enforce the traditional token representation, you can +set the `BinaryOperators` and `OverloadedOperators` options to ``&&,

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:28-29 + +Alternative Token Representation + + carlosgalvezp wrote: > Personally I find this to be a

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/operators-representation.rst:16 +To configure the check to enforce the traditional token representation, you can +set the `BinaryOperators` and `OverloadedOperators` options to

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL updated this revision to Diff 503364. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144522/new/ https://reviews.llvm.org/D144522 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt cla

[PATCH] D144522: [clang-tidy] Add readability-operators-representation check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL added a comment. PiotrZSL updated this revision to Diff 499306. Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp. PiotrZSL marked