jhuber6 added inline comments.
Comment at: clang/test/Driver/amdgpu-toolchain.c:7
// RUN: %clang -### -g --target=amdgcn-mesa-mesa3d -mcpu=kaveri %s 2>&1 |
FileCheck -check-prefix=DWARF_VER %s
// AS_LINK: "-cc1as"
arsenm wrote:
> should add a test for thinlt
arsenm added inline comments.
Comment at: clang/test/Driver/amdgpu-toolchain.c:7
// RUN: %clang -### -g --target=amdgcn-mesa-mesa3d -mcpu=kaveri %s 2>&1 |
FileCheck -check-prefix=DWARF_VER %s
// AS_LINK: "-cc1as"
should add a test for thinlto?
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc45d2df05e0e: [Clang] Add options in LTO mode when cross
compiling for AMDGPU (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144505/new
jhuber6 added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:545
+addLTOOptions(getToolChain(), Args, CmdArgs, Output, Inputs[0],
+ C.getDriver().getLTOMode() == LTOK_Thin);
CmdArgs.push_back("-shared");
JonChesterfiel
JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.
NVM the above, all the other call sites to addLTOOptions have that test in them
so it must be fine
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:/
JonChesterfield added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:545
+addLTOOptions(getToolChain(), Args, CmdArgs, Output, Inputs[0],
+ C.getDriver().getLTOMode() == LTOK_Thin);
CmdArgs.push_back("-shared");
What's
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, arsenm, yaxunl, JonChesterfield,
tianshilei1992.
Herald added subscribers: kosarev, kerbowa, inglorion, tpr, dstuttard, jvesely,
kzhuravl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscr
