[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG465ee9bfb26d: [clangd] Publish diagnostics with stale preambles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

kadircet updated this revision to Diff 499224. kadircet marked 7 inline comments as done. kadircet added a comment. - Notify preamble peer before building an AST, to concurrently build fresh preamble & AST. - Refactoring for tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

sammccall added a comment. Looks pretty good. I think we can build the main file & preamble in parallel. Otherwise nits. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:946 +// gurantee eventual consistency. +if (LatestPreamble && Config::current().Diagnostics.All

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.