This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG83cd4bea015f: [Clang] Teach buildFMulAdd to peek through
fneg to find fmul. (authored by craig.topper).
Repository:
rG LLVM Github Monorepo
CHANG
kpn accepted this revision.
kpn added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D17/new/
https://reviews.llvm.org/D17
___
cfe-
lhames added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3738
- assert(!(negMul && negAdd) && "Only one of negMul and negAdd should be
set.");
-
Value *MulOp0 = MulOp->getOperand(0);
craig.topper wrote:
> kpn wrote:
> > If I'm reading thi
craig.topper added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3738
- assert(!(negMul && negAdd) && "Only one of negMul and negAdd should be
set.");
-
Value *MulOp0 = MulOp->getOperand(0);
kpn wrote:
> If I'm reading this right it looks l
kpn added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3738
- assert(!(negMul && negAdd) && "Only one of negMul and negAdd should be
set.");
-
Value *MulOp0 = MulOp->getOperand(0);
If I'm reading this right it looks like the assert() wasn'
craig.topper created this revision.
craig.topper added reviewers: efriedma, aaron.ballman, andrew.w.kaylor, kpn,
spatel, uweigand.
Herald added a subscriber: StephenFan.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added a project: clang.
Allows us to handle
