[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d585c9dd07d: [PowerPC] Use member function to determine PowerPC Secure PLT (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim accepted this revision. dim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad updated this revision to Diff 499222. brad added a comment. rename function and clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp llvm/

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim added a comment. In D14#4142146 , @MaskRay wrote: > `isPPC32SecurePlt` is probably more accurate. I agree, good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llv

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

MaskRay accepted this revision. MaskRay added a comment. `isPPC32SecurePlt` is probably more accurate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 ___ cfe-c

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. Yes, this is quite a bit nicer. Maybe run the isPPCSecurePlt() function through clang-format, just to be sure of the style? (I think you can ignore the weird libFuzzer Unit Test errors, they don't s

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad updated this revision to Diff 499018. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ https://reviews.llvm.org/D14 Files: clang/lib/Driver/ToolChains/Arch/PPC.cpp llvm/include/llvm/TargetParser/Triple.h llvm/lib/Target/Power

[PATCH] D144444: [PowerPC] Use member function to determine PowerPC Secure PLT

brad created this revision. brad added a reviewer: nemanjai. brad added a project: LLVM. Herald added subscribers: steven.zhang, shchenz, kbarton, hiraditya. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: