This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGee815ff2ce8d: [PowerPC] Fix the implicit casting for the
emulated intrinsics (authored by maryammo).
Repository:
rG LLVM Github Monorepo
CHANGES
maryammo updated this revision to Diff 499273.
maryammo added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144293/new/
https://reviews.llvm.org/D144293
Files:
clang/lib/Headers/ppc_wrappers/emmintrin.h
clang
maryammo added inline comments.
Comment at: clang/lib/Headers/ppc_wrappers/smmintrin.h:310
__charmask = vec_gb(__charmask);
- __v8hu __shortmask = (__v8hu)vec_unpackh(__charmask);
+ __v8hu __shortmask = (__v8hu)vec_unpackh((__v16qi)__charmask);
#ifdef __BIG_ENDIAN__
---
amyk added inline comments.
Comment at: clang/lib/Headers/ppc_wrappers/emmintrin.h:57
typedef __vector unsigned char __v16qu;
+typedef __vector float __v2f;
nemanjai wrote:
> The name `__v2f` seems strange since `__vector float` is a vector of 4
> `float` val
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM as long as the naming nit is addressed.
Comment at: clang/lib/Headers/ppc_wrappers/emmintrin.h:57
typedef __vector unsigned char __v16qu;
+typedef __vector float __
maryammo created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
Herald added a project: All.
maryammo requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch is to fix some implicit castings for emulated intrinsics
