This revision was automatically updated to reflect the committed changes.
Closed by commit rG495b65348023: [RISCV] Add missing plumbing and tests for zfa
(authored by reames).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144288/new/
https://reviews
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144288/new/
https://reviews.llvm.org/D144288
___
cfe-commits mailing list
c
reames updated this revision to Diff 498512.
reames added a comment.
Address review comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144288/new/
https://reviews.llvm.org/D144288
Files:
clang/test/Preprocessor/riscv-target-features.c
llvm/lib/Support/RISCVISAInfo.cpp
llvm/tes
craig.topper added inline comments.
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:853
// Note: The table needs to be sorted by name.
static constexpr ImpliedExtsEntry ImpliedExts[] = {
{{"v"}, {ImpliedExtsV}},
I think zfa should imply F here?
Repository:
reames created this revision.
reames added reviewers: craig.topper, asb, Joshua-401, kito-cheng, lbenes,
jrtc27.
Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, jdoerfert,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult,
