[PATCH] D144115: [clang] Extend pragma dump to support expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG467ed2798772: [clang] Extend pragma dump to support expressions (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 508086. Endill added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 507843. Endill added a comment. - Handle expressions as unevaluated operands - Numerous fixes to documentation wording - Add release notes entry - Prevent generic "unknown argument" diagnostic from being issued when other more specific diagnostics have been em

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:731-736 +} else if (E.get()->isTypeDependent()) { + PP.Diag(StartLoc, diag::warn_pragma_debug_type_dependent_argument) +<< SourceRange(StartLoc, Tok.getLocation()); +} else if (E.get()-

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:15-17 #include "clang/Basic/TargetInfo.h" +#include "clang/Lex/LexDiagnostic.h" #include "clang/Lex/Preprocessor.h" Endill wrote: > aaron.ballman wrote: > > > I'm using `warn_prag

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. Thank you for review! Comment at: clang/lib/Parse/ParsePragma.cpp:15-17 #include "clang/Basic/TargetInfo.h" +#include "clang/Lex/LexDiagnostic.h" #include "clang/Lex/Preprocessor.h" aaron.ballman wrote: > I'm using `warn_pragma_debug_

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added a comment. You should also add a release note to clang/docs/ReleaseNotes.rst so users know about the new functionality. Comment at: clang/docs/LanguageExtensions.rst:4884 +Syntax is the following: `#pragma clang __debug `. +Note that all of them are a subj

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.llvm.org/D144115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill updated this revision to Diff 504673. Endill added a comment. - Diagnose dependent expressions - Move AST dumping from parser to sema - Add documentation - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144115/new/ https://reviews.l

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added a comment. In D144115#4148026 , @Endill wrote: > Despite having a dozen of `#pragma __debug` directives, none of them are > tested neither mentioned in any kind of documentation, including release > notes. Are you sure about this? If

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. Thank you for reviewing this! In D144115#4147440 , @aaron.ballman wrote: > You should add test coverage for the changes, especially around things like > dependent expressions, ADL use, etc. Also, the changes need a release note

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added a comment. Thanks for this! You should add test coverage for the changes, especially around things like dependent expressions, ADL use, etc. Also, the changes need a release note and the new functionality should be explicitly documented. Comment at: clang/

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill created this revision. Endill added reviewers: clang-language-wg, aaron.ballman. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend `#pragma clang __debug dump` to support not only single ident