[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

2023-02-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. > `[llvm] ` `[SCEV]` is a more common tag for ScalarEvolution patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

2023-02-22 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D144035#4145662 , @MaskRay wrote: >> Full context at https://github.com/llvm/llvm-project/issues/60668. > > Best to leave a simplified description in the summary so that a reader > doesn't have to go to the external link a

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

2023-02-22 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan updated this revision to Diff 499668. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 Files: llvm/lib/Analysis/ScalarEvolution.cpp llvm/test/Ana

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

2023-02-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. > Full context at https://github.com/llvm/llvm-project/issues/60668. Best to leave a simplified description in the summary so that a reader doesn't have to go to the external link and summarize the discussions themselves. This SCEV function is invoked by `FunctionPass M

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

2023-02-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. LG Comment at: clang/test/CodeGenCXX/pr60668.cpp:1 +// RUN: %clang --target=aarch64-unknown-linux-gnu -O1 -fvisibility=hidden \ +// RUN: -fsanitize=hwaddress -fsanitize=undefined -std=c++17 -fno-exceptions \ We try avoiding .cc to as

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

2023-02-21 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. In D144035#4143030 , @pcc wrote: > Passes shouldn't be replacing aliases with aliasees in general, see D66606 > . The right fix is to fix SCEV to not do > that. Updated Repository: rG LL