vporpo added a comment.
Yeah sorry about that, I reverted it here: b5f239363a3 Revert "[NFC][IR] Make
Module::getGlobalList() private"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144027/new/
https://reviews.llvm.org/D144027
fmayer added a comment.
This seems to have broken our buildbot:
https://lab.llvm.org/buildbot/#/builders/169/builds/16797/steps/8/logs/stdio
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache
/b/sanitizer-x86_64-linux-qemu/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0
-D_DEBUG -D_GLIBCXX_
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGed3e3ee9e30d: [NFC][IR] Make Module::getGlobalList() private
(authored by vporpo).
Changed prior to commit:
https://reviews.llvm.org/D144027?vs=49
vporpo updated this revision to Diff 497403.
vporpo added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144027/new/
https://reviews.llvm.org/D144027
Files:
clang/lib/CodeGen/CGHLSLRuntime.cpp
clang/lib/CodeGen/CGObjCMac.cpp
vporpo added inline comments.
Comment at: llvm/unittests/IR/ModuleTest.cpp:47-49
// Sort the globals by name.
EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare));
-M.getGlobalList().sort(compare);
I removed this because it is tes
vporpo updated this revision to Diff 497367.
vporpo marked an inline comment as done.
vporpo added a comment.
Removed commented out lines from ModuleTest.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144027/new/
https://reviews.llvm.org/D144027
aeubanks accepted this revision.
aeubanks added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/unittests/IR/ModuleTest.cpp:49
EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare));
-M.getGlobalList().sort(compare);
-
vporpo created this revision.
vporpo added a reviewer: aeubanks.
Herald added subscribers: mattd, gchakrabarti, asavonic, snehasish, ormris,
hiraditya.
Herald added a project: All.
vporpo requested review of this revision.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, jholewin
