[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. In D143974#4267320 , @nridge wrote: > The patch is causing `initialize-params.test` to fail, fix coming right up. Fixed in https://github.com/llvm/llvm-project/commit/28575f41cd7df98012fb15f18434411a941ec228. Repository: rG L

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. The patch is causing `initialize-params.test` to fail, fix coming right up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/ https://reviews.llvm.org/D143974 ___ cfe-comm

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f6a904b2f3d: [clangd] Inactive regions support via dedicated protocol (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:977 + return CB(InpAST.takeError()); +// Include inactive regions in semantic highlighting tokens only if the +// client doesn't support a dedicated protocol for being informed about

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge updated this revision to Diff 513450. nridge marked 2 inline comments as done. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/ https://reviews.llvm.org/D143974 Files: clang-tools-extra/clangd/

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, the implementation looks good. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:977 + return CB(InpAST.takeError()); +// Include inactive regions in sem

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:977 + return CB(InpAST.takeError()); +// Include inactive regions in semantic highlighting tokens only if the +// client doesn't support a ded

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge updated this revision to Diff 511957. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/ https://reviews.llvm.org/D143974 Files: clang-tools-e

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

hokein added a comment. Thanks, and sorry for late response. The patch looks good to me in general. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:590 {"foldingRangeProvider", true}, + {"inactiveRegionsProvider", true}, }; nit: add tra

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. The issue addressed by this patch is attracting a steady stream of user interest (two recent examples are https://github.com/clangd/clangd/issues/1545 and https://github.com/clangd/vscode-clangd/issues/469). A review would be appreciated :) Repository: rG LLVM Github

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge added a comment. Corresponding client-side support is implemented for vscode in the latest version of https://github.com/clangd/vscode-clangd/pull/193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143974/new/ https://reviews.llvm.org/D1439

[PATCH] D143974: [clangd] Inactive regions support via dedicated protocol

nridge created this revision. nridge added reviewers: sammccall, kadircet, hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. T