[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

2023-02-12 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D143867#4121874 , @Scarlet1ssimo wrote: >> The test passes on main. Are you sure about the reproducer? > > This happens on versions from release/10.x to release/15.x. Since 16.x, this > file gets refactored and no such probl

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

2023-02-12 Thread Scarlet via Phabricator via cfe-commits
Scarlet1ssimo added a comment. > The test passes on main. Are you sure about the reproducer? This happens on versions from release/10.x to release/15.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143867/new/ https://reviews.llvm.org/D143867 ___

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

2023-02-12 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D143867#4121841 , @Scarlet1ssimo wrote: > In D143867#4121835 , @steakhal > wrote: > >> Looks sensible to me. >> Do you have a test for triggering the previous assertion? > > I do hav

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

2023-02-12 Thread Scarlet via Phabricator via cfe-commits
Scarlet1ssimo added a comment. In D143867#4121835 , @steakhal wrote: > Looks sensible to me. > Do you have a test for triggering the previous assertion? I do have prepared a test case like: int testA(void) { return 0/0; } // RUN: %clang_analyze_cc1

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

2023-02-12 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. Looks sensible to me. Do you have a test for triggering the previous assertion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143867/new/ https://reviews.llvm.org/D143867 ___ cf

[PATCH] D143867: [analyzer] Fix SARIF column location assertion crash

2023-02-12 Thread Scarlet via Phabricator via cfe-commits
Scarlet1ssimo created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. Scarlet1ssimo requested review of th